Add targets to create and manage FakeItEasy.user.props

[blairconrad]

Augments #1662

[thomaslevesque]

Thanks @blairconrad, very nice! The regex makes me really uncomfortable, though...

[thomaslevesque]

I... don't even understand how that regex works. How about using Linq to XML? I think the code would be almost as short, and much easier to understand.

[blairconrad]

Done. And at the risk of tooting your horn, I think it's an improvement!

[thomaslevesque]

Thanks for indulging me, @blairconrad. I have a few more comments... Sorry!

[thomaslevesque]

I tend to avoid using Descendants, because it can match elements unrelated to the one we're looking for (e.g. a BuildProfile element in an ItemGroup). I usually try to specify the path more precisely, e.g. xmlDoc.Root.Elements("PropertyGroup").Elements("BuildProfile").FirstOrDefault().

Anyway, the current code doesn't handle the case where the PropertyGroup or BuildProfile element is missing... You probably need something like this:

var buildProfileElement = xmlDoc.Root.Elements("PropertyGroup").Elements("BuildProfile").FirstOrDefault();
if (buildProfileElement is null)
{
    var propertyGroupElement = xmlDoc.Root.Element("PropertyGroup");
    if (propertyGroupElement is null)
    {
        propertyGroupElement = new XElement("PropertyGroup");
        xmlDoc.Root.Add(propertyGroupElement);
    }
    buildProfileElement = new XElement("BuildProfile");
    propertyGroupElement.Add(buildProfileElement);
}
...

Well, it ended up being much longer than the original version... But to be fair, it also handles more cases!

[blairconrad]

I figured there'd be a low chance that the file would exist and be that malformed. However, I wasn't considering that users would fail to be notified that the transformation wasn't made. Glad you thought of it.

Pushed a fixup. I deviated from your suggestions slightly

1. I started checking for missing elements at PropertyGroup, not BuildProfile
2. I assumed only a singled BuildProfile element in the PropertyGroup
3. (more a deviation from my original), I stopped preserving whitespace on load, since it easily allowed me to indent the output on save. Without that change, newly-added elements were on the same line as their parents

[blairconrad]

… and added a new fixup, since you seem to not have digested the last one yet. I extracted GetOrAddElement.

[thomaslevesque]

Almost there ;)

[thomaslevesque]

This assumes the BuildProfile element is in the first PropertyGroup... it might not be the case. That's why I first looked for BuildProfile in my suggestion.

[blairconrad]

Your error- and future-proofing is infuriating!
Infuriatingly correct and appropriate.

I've pushed a thing. It's exactly your thing, so it probably satisfies.
(Oh, as before, I'm no longer preserving whitespace, as it seemed the lesser of the two formatting evils.)

Sorry to have taken so much of your time with my whim.

[thomaslevesque]

(Oh, as before, I'm no longer preserving whitespace, as it seemed the lesser of the two formatting evils.)

👍

Sorry to have taken so much of your time with my whim.

You haven't!

[thomaslevesque]

Thanks, @blairconrad!

[thomaslevesque]

Oh, I can't merge yet... you need to squash first

[blairconrad]

Thanks. Squashed. I enjoyed your comments!

[afakebot]

This change has been released as part of FakeItEasy 6.0.0-beta.1.