Small fixes after upgrade to .NET 5.0 SDK #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaslevesque
commented
Nov 16, 2020
tests/FakeItEasy.Tests.Approval/ApprovedApi/FakeItEasy.Extensions.ValueTask/net45.approved.txt
Show resolved
Hide resolved
|
Thanks, @thomaslevesque. I generally like the changes, but Ubuntu doesn't. |
Oh. I can build without issue on WSL 2. |
|
It's fixed! |
|
Thanks for the merge. I have a pretty big one incoming after that, to address #1798. |
|
This change has been released as part of FakeItEasy 7.0.0-beta.1. |
|
This change has also been released as part of FakeItEasy 7.0.0. |
This was referenced Mar 16, 2021
Merged
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still warnings NETSDK1138 warnings due to netcoreapp1.0 and netcoreapp3.0 being out of support, but at least we should have a working build again