Remove compilation constant FEATURE_THREAD_CURRENTCULTURE #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #else | ||
| CultureInfo.CurrentCulture = this.originalCulture; | ||
| CultureInfo.CurrentUICulture = this.originalUiCulture; | ||
| #endif |
There was a problem hiding this comment.
Any specific reason to keep Thread.CurrentThread.CurrentCulture instead of CultureInfo.CurrentCulture? Both work, but CultureInfo.CurrentCulture has always felt more natural to me.
Doesn't really matter though; if you prefer to keep it this way, I'll merge as is.
|
I... Did not think. Just removed branch with constant. Will rework.
…On Sat, Nov 21, 2020, 08:50 Thomas Levesque, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/FakeItEasy.Tests.TestHelpers/UsingCultureAttribute.cs
<#1802 (comment)>
:
> Thread.CurrentThread.CurrentCulture = this.originalCulture;
Thread.CurrentThread.CurrentUICulture = this.originalUiCulture;
-#else
- CultureInfo.CurrentCulture = this.originalCulture;
- CultureInfo.CurrentUICulture = this.originalUiCulture;
-#endif
Any specific reason to keep Thread.CurrentThread.CurrentCulture instead
of CultureInfo.CurrentCulture? Both work, but CultureInfo.CurrentCulture
has always felt more natural to me.
Doesn't really matter though; if you prefer to keep it this way, I'll
merge as is.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1802 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAY7YFICHUPREBWOCNKXF5LSQ7ATZANCNFSM4T5YZDFA>
.
|
blairconrad
force-pushed
the
remove-feature-thread-currentculture
branch
from
36d2322
to
b6a9313
Compare
thomaslevesque
approved these changes
Nov 21, 2020
|
Flipped. I just amended, rather than fixupping. That would've added confusion, I think. |
|
Thanks @blairconrad! |
|
Thank you. I like your version better too. |
|
Thanks for
|
|
This change has been released as part of FakeItEasy 7.0.0-beta.1. |
|
This change has also been released as part of FakeItEasy 7.0.0. |
This was referenced Mar 16, 2021
Merged
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #1801 a bit, as suggested by @thomaslevesque in #1801 (comment)