Clarify use of WithArgumentsForConstructor expression #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/creating-fakes.md
Outdated
| // The constructor seen here is never actually invoked. It is an expression and it's purpose | ||
| // is purely to communicate the constructor arguments which will be extracted from it | ||
| // Since the constructor call seen here is an expression, it is not invoked at this point | ||
| // in the code. (In fact no instance of `FooClass` will ever be constructed.) Instead, the |
There was a problem hiding this comment.
In fact no instance of
FooClasswill ever be constructed
I think this could be confusing too. The fake will be an instance of the proxy class, but it's still "an instance of FooClass", in the sense that fake is FooClass is true.
There was a problem hiding this comment.
grumble grumble
working on it
blairconrad
force-pushed
the
constructor-docs
branch
from
6f12dde
to
4a6c8ba
Compare
thomaslevesque
approved these changes
Aug 30, 2021
|
Oh, thank you, @thomaslevesque. |
|
This change has been released as part of FakeItEasy 7.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #1854, where @Bludator had noted that the original documentation was confusing.