Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs-building dependencies #1971

Merged
merged 1 commit into from Nov 6, 2023
Merged

Update docs-building dependencies #1971

merged 1 commit into from Nov 6, 2023

Conversation

blairconrad
Copy link
Member

Closes #1969.

@blairconrad blairconrad added this to the vNext milestone Nov 6, 2023
@blairconrad
Copy link
Member Author

blairconrad commented Nov 6, 2023 •
edited

I figured why not update everything while we're going:

pip-compile --upgrade requirements.in

I saw no difference in the docs that were produced.

@blairconrad
Copy link
Member Author

I compared the contents of the docs trees incorrectly. There are differences to the produced docs. Checking with eyeballs.

@blairconrad blairconrad added the 👀 publish-docs-preview Add this label to a pull request to trigger the publication of a preview of the documentation label Nov 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

✅ Publish docs preview: Successfully published here.

@blairconrad
Copy link
Member Author

Looks about the same to me.

@thomaslevesque
Copy link
Member

thomaslevesque commented Nov 6, 2023 •
edited

So what are the differences? Small changes in the code, but nothing visible?

@blairconrad
Copy link
Member Author

blairconrad commented Nov 6, 2023 •
edited

So what are the differences? Small changes in the code, but nothing visible?

Exactly. Sorry I wasn't clear.

thomaslevesque
thomaslevesque approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@thomaslevesque thomaslevesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blairconrad!

@thomaslevesque thomaslevesque merged commit eba236e into FakeItEasy:master Nov 6, 2023
6 checks passed
@blairconrad
Copy link
Member Author

Thank you, @thomaslevesque.

@blairconrad blairconrad deleted the update-docs-deps branch November 6, 2023 19:51
@afakebot
Copy link

afakebot commented Nov 7, 2023

This change has been released as part of FakeItEasy 8.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaslevesque thomaslevesque thomaslevesque approved these changes

Assignees
No one assigned
Labels
🏗️ build 👀 publish-docs-preview Add this label to a pull request to trigger the publication of a preview of the documentation
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blairconrad @thomaslevesque @afakebot