refactor: treat StyleCop violations as warnings in Release builds #397
Conversation
| @@ -60,7 +60,7 @@ | |||
| <DocumentationFile>Bin\Release\FakeItEasy.xml</DocumentationFile> | |||
| <CodeAnalysisRuleSet>..\FakeItEasy.ruleset</CodeAnalysisRuleSet> | |||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | |||
| <StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings> | |||
| <StyleCopTreatErrorsAsWarnings>true</StyleCopTreatErrorsAsWarnings> | |||
There was a problem hiding this comment.
All this looks great. I can't reconcile StyleCop violations being warnings and TreatingWarningsAsErrors being true not equating to violations are still errors, but it works as intended. I'm getting warnings only for the extra violations I injected here. PASS!
There was a problem hiding this comment.
TreatWarningsAsErrors is for the compiler.
Hmmmm... I think we should probably also relax that to false for Release builds too.
There was a problem hiding this comment.
What? Seriously? We want to treat all warnings as warnings for release builds? No!
Really?
There was a problem hiding this comment.
I'm leaning very much towards being on the lenient side on things like this when it comes to OSS contributions. Perhaps this is a step too far though.
refactor: treat StyleCop violations as warnings in Release builds
|
I'm coming around to the "lenient" view, but perhaps one step at a time? Compiler warnings seem to be a slightly different beast. Also, I've already been bitten by the lenient StyleCop warnings. We need a set of warning severities for owners. Or at least me! |
|
We can't have been bitten yet, we've only just merged this PR |
|
I bit myself. |
fixes #262