changed build script to allow adoption of SemVer #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uspec and informational version using first 3 numbers incremented version to 1.8.0.0 including updated VersionAssemblyInfo.cs
|
I'm leaving this one open for @FakeItEasy/owners to review |
| @@ -82,6 +85,7 @@ | |||
| <AssemblyInfo OutputFile="%(UpdateVersionFiles.FullPath)" CodeLanguage="CS" | |||
| AssemblyVersion="$(VersionNumber)" | |||
| AssemblyFileVersion="$(VersionNumber)" | |||
| AssemblyInformationalVersion="$(AssemblyInformationalVersion)" | |||
There was a problem hiding this comment.
Ouch - I didn't realise this file was using tabs instead of spaces! See #36 (comment)
|
@FakeItEasy/owners if there are no objections, I'll probably merge this one this evening and close #37 |
|
It looks good to me. I don't always have time to answer quickly but I trust you 100% so just go ahead. I'm very happy to have you onboard, just incredible work so far! Thanks a bunch! |
adamralph
added a commit
that referenced
this pull request
Feb 12, 2013
changed build script to allow adoption of SemVer fixes #37
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #37