Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Castle.Core netstd dependency to match project.json #922

Merged
merged 1 commit into from Nov 23, 2016

Conversation

blairconrad
Copy link
Member

Without this, consumers of our package find

 System.MissingMethodException : Method not found: 'System.Collections.Generic.IList`1<Castle.DynamicProxy.CustomAttributeInfo> Castle.DynamicProxy.ProxyGenerationOptions.get_AdditionalAttributes()'.

@blairconrad blairconrad added this to the 3.0.0-pre milestone Nov 23, 2016
@blairconrad
Copy link
Member Author

workaround: reference 4.0.0-beta002 in the test project's project.json.

@thomaslevesque
Copy link
Member

Oops! Forgot to update that.

@thomaslevesque thomaslevesque merged commit a44b11c into FakeItEasy:master Nov 23, 2016
@thomaslevesque
Copy link
Member

Thanks for the fix @blairconrad!

@blairconrad
Copy link
Member Author

😉

Thanks for the merge!

Now, as a bug that was introduced in 3.0.0-alpha001, should we put in the release notes for 3.0.0-alpha002?
(But not in 3.0.0, when we release that?)

@adamralph
Copy link
Contributor

Now, as a bug that was introduced in 3.0.0-alpha001, should we put in the release notes for 3.0.0-alpha002?
(But not in 3.0.0, when we release that?)

I think so. Perhaps it would be easier to have real milestones for each alpha, beta, etc.? Rather than the 3.0.0-pre "catch-all" milestone?

@blairconrad
Copy link
Member Author

Perhaps it would be easier to have real milestones for each alpha, beta, etc.? Rather than the 3.0.0-pre "catch-all" milestone?

This meshes nicely with my belief that we should "treat all releases the same". I'd go so far as to make a milestone, release issue, and release for every release.

Along with that, I'd commit the full version number, and ditch the version_suffix environment variable. But perhaps that's a story for another day.

In the short term, I'll add this to the release notes.

@adamralph
Copy link
Contributor

adamralph commented Nov 23, 2016

One reason I like version_suffix is that it allows us to build RC and RTM
from the same commit.

@blairconrad
Copy link
Member Author

One reason I like version_suffix is that it allows us to build RC and RTM.

Yeah. I know. I have contrary views. But that's okay. I don't mind. 😼

@blairconrad blairconrad deleted the fix-castle.core branch March 1, 2017 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants