Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix for #899 to 2.x from 3.0.0 prereleases #947

Merged
merged 1 commit into from
Dec 14, 2016

Conversation

thomaslevesque
Copy link
Member

Connects to #899

(I just cherry-picked the merge commit)

Fix bug for constraint on ref or out argument
(cherry picked from commit 8e8817f)
@blairconrad
Copy link
Member

I did not know that you could cherry-pick a merge commit! I'd've cherry-picked the 3 commits. Cool.

@blairconrad
Copy link
Member

Looks great, @thomaslevesque. Thanks!

@blairconrad blairconrad merged commit 0f7065b into FakeItEasy:support-2 Dec 14, 2016
@blairconrad blairconrad added this to the 2.3.2 milestone Dec 14, 2016
@thomaslevesque thomaslevesque deleted the backport-issue899 branch December 14, 2016 08:35
@thomaslevesque
Copy link
Member Author

I did not know that you could cherry-pick a merge commit! I'd've cherry-picked the 3 commits. Cool.

You can; you just have to specify which parent you want with -m

@blairconrad
Copy link
Member

This issue has been released in FakeItEasy 2.3.2
https://github.com/FakeItEasy/FakeItEasy/releases/tag/2.3.2

Thanks for identifying it, @thunderbird55. Look for your name in the release notes. 🏆

@blairconrad blairconrad removed this from the 2.3.2 milestone Dec 26, 2016
@blairconrad blairconrad changed the title Backport fix for #899 to 2.x Backport fix for #899 to 2.x from 3.0.0 prereleases Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants