Remove whitespace from beginning of el_GR phone numbers #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Schmelz daniel@schmelz.org
What is the reason for this PR?
Greek phone numbers have a whitespace at the beginning of the string because they are generated by combining an
internationalCodePrefix
with the rest of the number.Faker/src/Faker/Provider/el_GR/PhoneNumber.php
Line 101 in ad43ce8
This prefix may be empty
Faker/src/Faker/Provider/el_GR/PhoneNumber.php
Line 11 in ad43ce8
which results in a leading space.
Author's checklist
Summary of changes
Fixes the issue by
trim
ming the generated phone numbers, covered by tests.Review checklist