-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uninitialized Base::unique #309
Conversation
@GrahamCampbell guess we can accept this BC right after updating the definition? |
Can we ensure that the BC check passes? |
@pimjansen how? The |
Ensure that the BC check allows it for now |
This looks fine to me. |
@simPod will you update the PR accordingly the code guidelines? We need a green build to pass |
@pimjansen how? The BC change is the point of this PR. $unique could always be null so it was a bug not to have it in type definition. Now the bug is fixed and it violates BC check, yes 🤔 |
In that case it will be a no fix since we are not running BC changes in our update policy for the current stream of Faker |
Should I remove "Fix" from a title and target a version where this can be fixed? |
What is the reason for this PR?
Author's checklist
Summary of changes
Base::unique
property was not initialized in constructor and did not allownull
. That may cause issues in classes accessing it while extendingBase
Review checklist