-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate falkordbrs #544
integrate falkordbrs #544
Changes from 57 commits
351a39f
41a7a6f
0ba578a
5358d33
2175df2
72e119b
1805a0f
7000d6b
000dd3e
2ff1098
baa42f6
3ac957a
7e6879b
11e6103
a48284f
1aedfd4
4b85282
cf582b7
3bb4e95
5316712
5536be5
e9b4083
25a0d51
3022533
4186542
be795a2
bd07f6c
c7d67da
06fccfe
830b2d1
d9bc166
d1bd8e4
3a3d2d4
03adde8
a8a6cdf
9a32839
eaa1676
34441cb
8af4d62
b78fa3c
72a0455
d3fbff7
235b72e
01c1cbb
2428bed
8223940
af831f4
076688e
eaebc6d
a945af2
c976699
d90c004
2375432
b407651
7cb2ddf
abdd3a8
446424b
917bfac
94c3bc3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,3 +67,5 @@ deps/GraphBLAS/Config/GraphBLAS.h.tmp | |
/venv/ | ||
/.vscode/ | ||
/1/ | ||
|
||
target |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
[workspace] | ||
resolver = "2" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what's the purpose of this line ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
members = [ | ||
"deps/FalkorDB-rs", | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
|
||
ifneq ($(SAN),) | ||
export FalkorDBRS=$(FalkorDBRS_BINDIR)/x86_64-unknown-linux-gnu/debug/libFalkorDB_rs.a | ||
AviAvni marked this conversation as resolved.
Show resolved
Hide resolved
|
||
else | ||
ifeq ($(DEBUG),1) | ||
export FalkorDBRS=$(FalkorDBRS_BINDIR)/debug/libFalkorDB_rs.a | ||
else | ||
export FalkorDBRS=$(FalkorDBRS_BINDIR)/release/libFalkorDB_rs.a | ||
endif | ||
endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
The script's execution confirmed that the
libFalkorDB_rs.a
file, necessary for linkingFalkorDBRS
, was not found. This indicates an issue with either the build process ofFalkorDBRS
or the setup of theFalkorDBRS_BINDIR
environment variable, which is supposed to point to the directory containing the library. It's crucial to ensure thatFalkorDBRS
is correctly built and that theFalkorDBRS_BINDIR
environment variable is accurately set to the directory wherelibFalkorDB_rs.a
is located. Addressing this issue is necessary for a successful build and linking process.Analysis chain
The addition of
FalkorDBRS
toFALKORDB_LIBS
is noted. However, based on previous comments, there seems to be an issue with finding thelibFalkorDB_rs.a
file, indicating thatFalkorDBRS
might not be properly built or located. It's crucial to ensure thatFalkorDBRS
is correctly built and available in the expected directory before proceeding with the linking process. This might involve verifying the build steps forFalkorDBRS
or adjusting the search paths to locate the library file correctly.Scripts Executed
The following scripts were executed for the analysis:
Script:
Length of output: 212