Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMHO you should remove default key and throw error, when key is not provided during installation #58

Closed
janjur opened this issue May 13, 2019 · 1 comment

Comments

@janjur
Copy link

janjur commented May 13, 2019

DEFAULT_KEY = 'Falldog'

@janjur janjur changed the title IMHO you should remove default key and throw error, when key is not provided IMHO you should remove default key and throw error, when key is not provided during installation May 13, 2019
@Falldog
Copy link
Owner

Falldog commented Jun 14, 2019

Thanks for your suggestion. I will remove default key setting
for both support install by pip and setup.py, need more testing

  1. pip install, I need to try read the password from os.env rather than STDIN
  2. setup.py should get the ability to read password from STDIN

Falldog added a commit that referenced this issue Feb 27, 2022
@Falldog Falldog closed this as completed Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants