Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jellyfinlogin): use externalHostname if set for forgetpassword link #526

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

Fallenbagel
Copy link
Owner

@Fallenbagel Fallenbagel commented Nov 6, 2023

Description

Implemented dynamic URL generation for the 'Forgot Password' feature. If jellyfin external hostname is set, the URL is generated based on it; otherwise, jellyfin hostname is used as the base URL. The URL includes additional parameters to handle emby support.

Screenshot (if UI-related)

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

Implemented dynamic URL generation for the 'Forgot Password' feature. If jellyfin external hostname
is set, the URL is generated based on it; otherwise, jellyfin hostname is used as the base URL. The
URL includes additional parameters to handle emby support.

fix #199, fix #424, re #212
@Fallenbagel Fallenbagel merged commit 364fb46 into develop Nov 6, 2023
6 checks passed
@Fallenbagel Fallenbagel deleted the fix-forget-password-button branch November 6, 2023 23:26
@Fallenbagel
Copy link
Owner Author

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant