-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: faDeck Directive #241
base: master
Are you sure you want to change the base?
Conversation
This looks great, @imheresamir . A very solid PR (thanks especially for the tests!) It looks like you haven't yet signed Famo.us's CLA: could you please do that so I can merge this in? http://famo.us/cla/ Thanks! |
Signed. I'm glad you like it 😄 |
Hi guys, Is there any news about that PR? Is it a dead PR that will never be merged? It seems to fit one of our needs and would love to try it. (we gonna try it anyway ;) ) Thanks |
transclude: true, | ||
scope: true, | ||
compile: function (tElem, tAttrs, transclude) { | ||
window.$f = $famous; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems weird to store $famous
into window.$f
.
Hi guys! This directive looks amazing: I've downloaded the code and tested it on local and it seems to work well. I just have a very strange issue: this error message appears in the browser console: Error: fa-options is not supported on FA-DECK This error is thrown from this file: https://github.com/Famous/famous-angular/blob/master/src/scripts/directives/fa-options.js#L41 The reason is that The strange part is when I try to change the directive name (from It looks like it works for all names but |
Added the Famo.us Deck view as a F/A
fa-deck
directive. This includes the new attributefa-open
which takes a "true" or "false" value and opens or closes the Deck accordingly.Added F/A Deck specific tests and an example app in the header comment which should make it easy to document.
Big thanks to Zack for the pointers!
Cheers,
Samir