Fixing cirular import #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ENUS in main settings.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a circular import when trying to override default ZINNIA_APP_MENUS in main settings.py.
I could not override the ZINNIA_APP_MENUS setting in the django.conf.settings because I must import the classes from zinnia.plugins.menu and that was a circular import.
I modified the code to use a list of strings instead a list of classes. If you provide a full class name such as 'zinnia.plugins.menu.TagEntry' it imports the module, and construct the class list. If you just provide a class name (not points in the string) it assume is a class defined in 'zinnia.plugins.menu'.