gh-614: Restored Viewer type-to-search feature. #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MKadaner
commented
Feb 4, 2023
MKadaner
commented
Feb 4, 2023
Let's wait and gather user feedback first. |
|
Makes perfect sense to me. Please ping me if you decide to complete this PR or just close it. Not that I do not have my own opinion, but I still do not hold it much above that of another user. |
MKadaner
force-pushed
the
mzk-viewer-search-first-key
branch
from
192635d
to
5cf3a4d
Compare
MKadaner
changed the title
MKadaner
force-pushed
the
mzk-viewer-search-first-key
branch
from
5cf3a4d
to
f2a5643
Compare
|
Done as a macro. Please review. |
alabuzhev
approved these changes
Feb 18, 2023
…ved in 6099. Now it is implemented as a macro, see View.TypeToSearch.lua. Thanks to all for the discussion and prototyping.
MKadaner
force-pushed
the
mzk-viewer-search-first-key
branch
from
f2a5643
to
1e017a1
Compare
|
Rebased, ready. Thanks. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On popular demand restored the Viewer type-to-search feature.
References
#622
Checklist
If not checked, I accept that this work might be rejected in favor of a different grand plan.
Details
As per the discussion, implemented as a macro.