Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the following 2 things.
I think it's a good idea to do this now because:
First: auto_ptr has been deprecated, and will actually be deleted in the future, according to Herb Sutter:
http://herbsutter.com/2014/11/24/updates-to-my-trip-report/
Second: right now it's still a drop-in replacement. unique_ptr has move-only semantics, but you're not doing any copying of auto_ptrs right now. In the future, if you try to do copying of ptrs, the compiler will stop you. If you then still want to do copying, you can switch to shared_ptr.
First: segfaulting is always bad
Second: this change would have saved me 5-10 minutes of debugging time, so I expect a similar thing might be true for other people.