Throw exception instead of segfaulting on attempt to acess ROM data before ROM set. #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you try to, for example, get the number of lives left before loading the ROM, the code should now throw a std::runtime_error.
Optionally, you could also write to a log and mention that this has occurred.
Seems superfluous - the user will see the exception.
Optionally, you could move that pointer check into another function to avoid repeating code.
Also seems a little unnecessary at this point, but I can see the merits.