Tetris support #93
Merged
Tetris support #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| int y = readRam(&system, 114); | ||
| reward_t score = 1 * (x & 0x000F) + 10 * ((x & 0x00F0) >> 4) + 100 * (y & 0x000F); | ||
| if (score > m_score) { | ||
| std::cerr << "Score=" << score << std::endl; |
There was a problem hiding this comment.
Please remove the printout.
|
Tetris support looks good, save for the few comments I made in the other PR (please address). |
|
(hopefully) I addressed all the issues regarding Tetris. If you want it to be called Tetris26 and not Tetris then I need to change the class names etc... |
|
LGTM. One thing I noticed is that the tetromino sequence is fixed and cyclical. I suspect randomly setting the CPU registers doesn't fix this beyond randomizing where you start in the sequence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added two changes I was missing (whem moving from master to dev)
hope it is working now.