Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing underscore to fix rendering #102

Merged
merged 1 commit into from Jan 17, 2023

Conversation

frankroeder
Copy link
Contributor

Description

Rendering the fetch environment raises an error, that get_gripper_xpos is not defined.
Looking into the code, I noticed that the leading underscore is missing, changing it from self.get_gripper_xpos to self._get_gripper_xpos resolved the issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@rodrigodelazcano
Copy link
Member

Thanks! LGTM

@rodrigodelazcano rodrigodelazcano merged commit c96abb9 into Farama-Foundation:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants