Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct point_obs slicing for achieved_goal in point_maze environments #105

Merged
merged 1 commit into from Feb 8, 2023

Conversation

dohmjan
Copy link
Contributor

@dohmjan dohmjan commented Feb 8, 2023

Description

Hello!

Right now achieved_goal = point_obs[2:] refers to velocities while it should be x, y positions instead (desired_goal is a position).
point_obs is eventually coming from np.concatenate([self.data.qpos, self.data.qvel]).ravel() in the PointEnv.

This PR corrects the slicing s.t. achieved_goal = point_obs[:2] refers to x, y positions.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

point_maze envs: point_obs[2:] referred to the velocities,
achieved_goal should be the x,y position (point_obs[:2]) instead
@rodrigodelazcano
Copy link
Member

Thaks @dohmjan! you are right about this

@rodrigodelazcano rodrigodelazcano merged commit 3ec0d68 into Farama-Foundation:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants