Correct point_obs slicing for achieved_goal in point_maze environments #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello!
Right now
achieved_goal = point_obs[2:]
refers to velocities while it should be x, y positions instead (desired_goal is a position).point_obs
is eventually coming fromnp.concatenate([self.data.qpos, self.data.qvel]).ravel()
in thePointEnv
.This PR corrects the slicing s.t.
achieved_goal = point_obs[:2]
refers to x, y positions.Type of change
Please delete options that are not relevant.
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)