Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

randomize maze environments temporary xml file name #185

Merged

Conversation

Kallinteris-Andreas
Copy link
Collaborator

Description

fixes issue #184 by assigning a unique name to all temporary asset files

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rodrigodelazcano
Copy link
Member

Hey @Kallinteris-Andreas thanks for the PR. Are there any other environments that require creating unique xml file names? The mamujoco environments do create custom xml's at runtime, does jinja already solve this issue?

@Kallinteris-Andreas
Copy link
Collaborator Author

mamjoco is affected by the same issue, i will make a PR later for mamujoco-v1 (it will be small release to update to gymnasium/mujoco-v5)

@rodrigodelazcano rodrigodelazcano merged commit 5a665ab into Farama-Foundation:main Oct 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants