Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes to support Jax 0.4 #373

Merged
merged 6 commits into from Jul 3, 2023

Conversation

vcharraut
Copy link
Contributor

@vcharraut vcharraut commented Mar 10, 2023

Description

Add changes to support jax>=0.4.0 and jaxlib>=0.4.0

Fixes #359

Note : There might be some typing imprecisions, I think some Any type could be remove since jax.Array is supposed to be general, but I wasn't so sure.

To add in the next major release

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pseudo-rnd-thoughts
Copy link
Member

pseudo-rnd-thoughts commented Mar 13, 2023

I think the direction we should take with this is to wait for v0.29 but we should keep this open until then
The reason is that python 3.7 still has 3 months until end of life so if just wait until to closer to the time

@pseudo-rnd-thoughts pseudo-rnd-thoughts added this to the v0.29 milestone Jun 21, 2023
@pseudo-rnd-thoughts
Copy link
Member

@charraut There has been a change of plan and the next release with be a major release allowing us to include this PR
Could resolve the conflicts then we should be good to merge

@vcharraut
Copy link
Contributor Author

@charraut There has been a change of plan and the next release with be a major release allowing us to include this PR Could resolve the conflicts then we should be good to merge

Done! Let me know if you need any specific changes

@pseudo-rnd-thoughts
Copy link
Member

Done! Let me know if you need any specific changes

Amazing, thanks

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit ea3a24a into Farama-Foundation:main Jul 3, 2023
11 checks passed
@vcharraut vcharraut deleted the update-jax-4 branch July 26, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Update to Jax 4
2 participants