Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the wrong nstep in _step_mujoco_simulation function of class MujocoEnv #424

Merged
merged 1 commit into from Apr 1, 2023
Merged

Fix the wrong nstep in _step_mujoco_simulation function of class MujocoEnv #424

merged 1 commit into from Apr 1, 2023

Conversation

xuanhien070594
Copy link
Contributor

@xuanhien070594 xuanhien070594 commented Mar 31, 2023 •
edited

Description

This fixes the incorrect value passed to the argument nstep in _step_mujoco_simulation function of class MujocoEnv, according to the discussion of issue #420:

Fixes # (420)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@Kallinteris-Andreas
Copy link
Collaborator

LGTM

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 7094298 into Farama-Foundation:main Apr 1, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xuanhien070594 @Kallinteris-Andreas @pseudo-rnd-thoughts