Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shimmy[gym] to shimmy[gym-v21] or shimmy[gym-v26] #433

Merged

Conversation

elliottower
Copy link
Contributor

Description

This updates some debug print lines which say to install shimmy[gym], because we are planning to change it to shimmy[gym-v21] and shimmy[gym-v26] for simplicity. Otherwise, there are installation issues with version of pyglet and it's not as user friendly to have to install these versions manually. Setting as draft until these changes are finalized in shimmy.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pseudo-rnd-thoughts
Copy link
Member

@elliottower Is there a reason that this is a draft?

@elliottower
Copy link
Contributor Author

elliottower commented Apr 11, 2023 via email

@elliottower elliottower marked this pull request as ready for review May 20, 2023 23:02
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is related to Pyright not this PR, therefore, merging

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit e8dd84f into Farama-Foundation:main May 22, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants