Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update homepage text and add logo #482

Merged

Conversation

elliottower
Copy link
Contributor

@elliottower elliottower commented May 2, 2023

Description

Text formatting changes from #471, going back to the text used in 0.28.1 which was more concise and cleaner for the homepage.

I also made the second sentence in the description not bold so it's easier to read at a glance and see that it's a maintained fork of OpenAI Gym. We can change that back if we want though.

Before: "The Gymnasium interface is simple, pythonic, and capable of representing general RL problems, and has a compatibility wrapper for old Gym environments:"

After: "Gymnasium is a maintained fork of OpenAI’s Gym library. The Gymnasium interface is simple, pythonic, and capable of representing general RL problems, and has a compatibility wrapper for old Gym environments:"

Edit: I've also changed the homepage styling to use the nice graphics we use in the GitHub and do a separate header and title (one long title is very ugly and I've had multiple people tell me it should be changed)

Edit2: Changed the word 'set' to collection as that was the previously used wording, and makes the second line look better (set makes all the text fall only on the top line).

Edit3: Changed wording according to internal discussions

3: firefox_xfloGjhtNk

2: firefox_pxOD80pEOY

1: firefox_hsr5dgShr2

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower elliottower changed the title Revert text for homepage, fix pyright in jax_to_torch Update homepage text and add logo May 2, 2023
@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 9e79e40 into Farama-Foundation:main May 2, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants