Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc bug fixes #516

Merged

Conversation

pseudo-rnd-thoughts
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts commented May 23, 2023

Description

While completing #444, I found various bugs and to make #444 purely about vectorising wrappers, this PR includes all of the bug fixes

List of bugs

  • Remove extra instance of kwargs in make_vec docstring
  • Update make_vec._create_env function to make with environments that don't specify a render_mode argument
  • Update VectorWrapper.reset, VectorWrapper.step and VectorWrapper.__set_attr__ type annotation
  • Fix VectorObservationWrapper.reset that is not updated to the new API with obs, info
  • Fix VectorObservationWrapper.step to remove additional observation
  • Fix VectorActionWrapper.step to correctly reference self.actions rather than self.action
  • Add type hinting to VectorRewardWrapper.step
  • Update the __getattr__ in gymnasium.experimental.wrappers to support gymnasium.experimental.wrappers.vector that is not a wrapper
  • Remove additional print statements in test_flatten_observation.py and test_spaces.py
  • Merge import wrapper testing into a single file
  • Update test_resize_observation.py to include parameterized and test for shape

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 22a00c2 into Farama-Foundation:main May 23, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant