Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds testing to check_env that closing a closed environment doesn't raise an error #564

Merged
merged 6 commits into from Jun 21, 2023
Merged

Adds testing to check_env that closing a closed environment doesn't raise an error #564

merged 6 commits into from Jun 21, 2023

Conversation

pseudo-rnd-thoughts
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts commented Jun 21, 2023 •
edited

Description

Finishes #534 which fixes #531

@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title Allow close closed Adds testing to check_env that closing a closed environment doesn't raise an error Jun 21, 2023
@pseudo-rnd-thoughts pseudo-rnd-thoughts mentioned this pull request Jun 21, 2023
Closed
10 tasks
@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit a40234f into Farama-Foundation:main Jun 21, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proposal] Explicitly requires to allow closing a closed environment
2 participants
@pseudo-rnd-thoughts @qgallouedec