Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swig to installation instructions for Box2D #683

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Add swig to installation instructions for Box2D #683

merged 1 commit into from
Aug 22, 2023

Conversation

btjanaka
Copy link
Contributor

@btjanaka btjanaka commented Aug 22, 2023

Description

As discussed in #662 and #677, it appears that swig must be installed separately before the box2d environments can be installed. This PR updates the documentation to reflect this requirement.

Fixes #662

Type of change

  • Bug fix (non-breaking change which fixes an issue)

This is more of a "bug" in the documentation.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • [N/A] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [N/A] My changes generate no new warnings
  • [N/A] I have added tests that prove my fix is effective or that my feature works
  • [N/A] New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 3af04d0 into Farama-Foundation:main Aug 22, 2023
11 checks passed
@turbotimon turbotimon mentioned this pull request Apr 10, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Installing box2d on colab
2 participants