Remove ordereddict in favour of python dict #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OrderedDictwere used for legacy reasons whendictwhere no insertion ordered (whichOrderedDictare).However, in Python 3.6, python dict were updated for speed and in the process added insertion ordering.
Therefore, this PR updates the return type of
Dictspace to be a python dict.However, we probably cannot remove the
self.spaces = sorted(spaces)as this could break old code that might flatten the dictionary or usenext, making this bug very difficult to discoverOriginal issue: #940