Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable check_env for JAX environments #998

Closed
wants to merge 1 commit into from

Conversation

Kallinteris-Andreas
Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas commented Apr 5, 2024

Description

@Kallinteris-Andreas Kallinteris-Andreas changed the title re-enable jax check_env re-enable check_env for jax environments Apr 6, 2024
@Kallinteris-Andreas Kallinteris-Andreas changed the title re-enable check_env for jax environments Re-enable check_env for JAX environments Apr 6, 2024
@pseudo-rnd-thoughts
Copy link
Member

I did this intentionally as if a user creates one of the jax environments then they will get "obs not in observation_space" as the observation spaces don't support jax arrays

@pseudo-rnd-thoughts
Copy link
Member

This was actually just disabling the passive environment checker applied on make not check_env

@pseudo-rnd-thoughts pseudo-rnd-thoughts deleted the Kallinteris-Andreas-patch-5 branch May 21, 2024 08:56
@pseudo-rnd-thoughts pseudo-rnd-thoughts restored the Kallinteris-Andreas-patch-5 branch May 21, 2024 08:56
@pseudo-rnd-thoughts pseudo-rnd-thoughts deleted the Kallinteris-Andreas-patch-5 branch May 21, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants