Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EzPickle to all envs #34

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Add EzPickle to all envs #34

merged 3 commits into from
Feb 10, 2023

Conversation

ffelten
Copy link
Collaborator

@ffelten ffelten commented Feb 7, 2023

No description provided.

@LucasAlegre LucasAlegre added the enhancement New feature or request label Feb 7, 2023
@LucasAlegre
Copy link
Member

Can I merge this? @ffelten

@ffelten
Copy link
Collaborator Author

ffelten commented Feb 8, 2023

Can I merge this? @ffelten

Waiting for @pseudo-rnd-thoughts 's input for the wrappers. We'll see next week I guess.

pseudo-rnd-thoughts
pseudo-rnd-thoughts approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. One point would be using keyword arguments over position arguments as it is easier to remember what a value means but it doesn't matter for this.

@ffelten ffelten merged commit 6dc669c into main Feb 10, 2023
@pseudo-rnd-thoughts pseudo-rnd-thoughts deleted the feature/pickle-all-envs branch August 18, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ffelten @LucasAlegre @pseudo-rnd-thoughts