Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gymnasium 0.29 #73

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Support Gymnasium 0.29 #73

merged 6 commits into from
Jul 24, 2023

Conversation

LucasAlegre
Copy link
Member

No description provided.

@LucasAlegre LucasAlegre self-assigned this Jul 20, 2023
@LucasAlegre LucasAlegre marked this pull request as draft July 20, 2023 17:47
@LucasAlegre LucasAlegre requested a review from ffelten July 20, 2023 17:57
@LucasAlegre
Copy link
Member Author

@ffelten I had to replace EzPickle with RecordConstructorArgs in the LinearReward wrapper for the tests to pass. However, I'm not sure if we should also do that for the other wrappers?

@LucasAlegre LucasAlegre marked this pull request as ready for review July 20, 2023 17:58
@ffelten
Copy link
Collaborator

ffelten commented Jul 24, 2023

Hi Lucas,

Thanks for the PR 🤟

@ffelten I had to replace EzPickle with RecordConstructorArgs in the LinearReward wrapper for the tests to pass. However, I'm not sure if we should also do that for the other wrappers?

I think we should do this for all wrappers:

Gymnasium has implemented this for all built-in wrappers but for external projects, should be added to each wrapper. To do this, call gym.utils.RecordConstructorUtils.init(self, …) in the first line of the wrapper’s constructor with identical l keyword arguments as passed to the wrapper’s constructor, except for env.
https://gymnasium.farama.org/gymnasium_release_notes/#release-v0-28-0

Regarding the PR in general:

  • We should bump the Gymnasium version in pyproject and probably in the testing workflow?
  • A PR linked to this should be done in baselines to at least test the bump on the algorithms.

I can find some time to help if needed.

@ffelten ffelten mentioned this pull request Jul 24, 2023
6 tasks
@LucasAlegre LucasAlegre merged commit 6a99279 into main Jul 24, 2023
10 checks passed
@LucasAlegre LucasAlegre deleted the support-gymnasium-0.29 branch July 24, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants