Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for fruit_tree env #81

Merged

Conversation

@tomekster
Copy link
Contributor Author

@LucasAlegre PR ready for review

TODO for later: fix rendering for tree_depth=7

@LucasAlegre LucasAlegre self-assigned this Jan 19, 2024
@LucasAlegre LucasAlegre added the enhancement New feature or request label Jan 19, 2024
Copy link
Collaborator

@ffelten ffelten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR :).

I would revert the changes in the docstring but otherwise mostly LGTM :-)

mo_gymnasium/envs/fruit_tree/fruit_tree.py Outdated Show resolved Hide resolved
mo_gymnasium/envs/fruit_tree/fruit_tree.py Show resolved Hide resolved
mo_gymnasium/envs/fruit_tree/assets/node.png Outdated Show resolved Hide resolved
@ffelten
Copy link
Collaborator

ffelten commented Jan 28, 2024

Additional note, you might need to re-run the script to generate the envs gifs for the website that one.

@tomekster
Copy link
Contributor Author

Additional note, you might need to re-run the script to generate the envs gifs for the website that one.

@ffelten I re-ran the script but it didn't generate any additional files. Did you expect additional gifs to be generated for the fruit_tree env?

@ffelten
Copy link
Collaborator

ffelten commented Jan 28, 2024

Additional note, you might need to re-run the script to generate the envs gifs for the website that one.

@ffelten I re-ran the script but it didn't generate any additional files. Did you expect additional gifs to be generated for the fruit_tree env?

Yup, I think you need to run the script from the docs/_scripts directory. It should generate the gifs in docs/_static

@tomekster
Copy link
Contributor Author

You were correct, I had to run it from that directory - I pushed new commit with gifs added

@ffelten
Copy link
Collaborator

ffelten commented Jan 28, 2024

You were correct, I had to run it from that directory - I pushed new commit with gifs added

Forgot to add/commit/push fruit tree? :-)

@tomekster
Copy link
Contributor Author

Whops! Was git-ignored. Added it now 🙌

@LucasAlegre
Copy link
Member

Thanks again @tomekster !

@LucasAlegre LucasAlegre merged commit 2bf89bf into Farama-Foundation:main Jan 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants