Add obs/act spaces when combining datasets #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younik
approved these changes
Nov 11, 2023
minari/utils.py
Outdated
Comment on lines
191
to
192
| assert all(dataset.action_space == datasets_to_combine[0].action_space for dataset in datasets_to_combine), "The datasets to combine must have the same action space" | ||
| assert all(dataset.observation_space == datasets_to_combine[0].observation_space for dataset in datasets_to_combine), "The datasets to combine must have the same observation space" |
There was a problem hiding this comment.
maybe change these lines to
if any(dataset.action_space != datasets_to_combine[0].action_space for dataset in datasets_to_combine):
raise ValueError("...")?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Datasets should have the same observation and action space before being combined. The spaces should also be stored as an attribute in case the dataset has different spaces from the env used to create the dataset (then spaces shouldn't be inferred when loading the dataset)
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)pytest -vand no errors are present.pytest -vhas generated that are related to my code to the best of my knowledge.