Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General cleanup #52

Merged
merged 6 commits into from May 19, 2023
Merged

Conversation

RedTachyon
Copy link
Member

@RedTachyon RedTachyon commented Apr 2, 2023

I'm going through the repository and fixing whatever minor issues I spot. For now I'm not doing anything significant, but I'll write down potentially more complex things that need to be fixed before a full release

  • data_collector.py#L102 -- self._current_seed has type str | int, which seems a bit sus
  • data_collectory.py#L140 -- There has to be a simpler way of writing this using defaultdict or setdefault or something like that
  • data_collector.py#L66-69 -- Can't the type hints be simple callables?
  • The type hint for EpisodeBuffer is meant (?) to convey that it's a nested dictionary where leaves are lists. This doesn't work because self._current_seed: int | str is one of the possible top-level values

@rodrigodelazcano rodrigodelazcano merged commit bd745bf into Farama-Foundation:main May 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants