-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some typing improvements, add py.typed #284
Some typing improvements, add py.typed #284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, this is very helpful.
Could you fix the pre-commit issues
Also, I believe minigrid is python 3.7+ so we can add from __future__ import annotations
for improved annotations. The pre-commit pyupgrade should do most of the hard work so just add the import and run pre-commit.
Do you use minigrid a lot? Would you be interested in helping with adding more features? If so, could you join the farama foundation discord (https://discord.gg/bnJ6kubTg6) and message me, PseudoRnd
…rder to prevent need for 2x runs
@pseudo-rnd-thoughts ok – I've added an I have only really just started using it for my project – some details here: #168 (comment). But would be happy to join the discord – can you resend an invite? It became invalid when discord tried to make me a new account :/ |
Thanks for the changes, here is a new link https://discord.gg/N8CwYyGt |
Description
MinigridEnv
api and elsewhere.py.typed
marker so that tooling like mypy will know to use minigrid's type annotations.setup.py
tominigrid
I did not find a
CONTRIBUTING.md
but didpre-commit
and ensured all tests pass.Type of change
Please delete options that are not relevant.
Checklist:
pre-commit
checks withpre-commit run --all-files