Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace random.py with np_random #74

Merged
merged 10 commits into from Nov 14, 2022

Conversation

hh2564
Copy link

@hh2564 hh2564 commented Nov 7, 2022

Description

Main changes: 
Remove random.py and replace with self.np_random

rand.float is now replaced with np_random.uniform
rand.bool is now replaced with np_random.integers(0,2) == 0
rand.choice is now replaced with list[np_random.choice(len(list))]
rand.color is now replaced with colorlist[np_random.choice(len(colorlist))]
pytest file is modified to compliant with deleting random.py

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good
Do you think this will be backward compatible?

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit b7c449a into Farama-Foundation:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants