Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chess documentation coordinates error #1002

Merged
merged 1 commit into from Jun 19, 2023
Merged

Conversation

elliottower
Copy link
Collaborator

@elliottower elliottower commented Jun 19, 2023

Description

This addressed a problem brought up in our discord, about how there was a typo in the equation to get the original coordinates from the flattened representation.

The markdown table I added is as follows (just showing chess notation for people unfamiliar, tested that it works using an online viewer)
firefox_f5oJYSL04u

Fixes # (issue), Depends on # (pull request)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Co-authored-by: James Mochizuki-Freeman <jameymmf@gmail.com>
@elliottower elliottower merged commit 8c759eb into master Jun 19, 2023
17 checks passed
@elliottower elliottower deleted the elliottower-patch-3 branch June 19, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant