Tests duplicated deleted from parametrized_envs #1074
Conversation
There was a problem hiding this comment.
Looks good to me, thanks for taking the time to fix this. Curious what the speedup will be in the CI. If you could also try to cross reference with the pytest runner file and see if we actually need both of these files (my guess is that was created first and this is the more comprehensive version of it, you could check git blame to figure out when each was created and stuff like that as well)
Yes I'll check in the next days an try to speed up test as much as possible, I can also check Gymnasium wrapper for max_cycles |
…ement so the screen gets properly rendered every time
1.) Added missing env so now run test for every env 2.)Added check that was previously run only by pytest_runner_test In this way now all_parameter_combs_test.py is combining the old version of itself with pytest_runner_test avoiding running repeated test
|
Looks good, only thing I'd say is try to at least do two parameter combinations per environment (I imagine the test will take about the same amount of time if you just remove the pytest runner test and do this, because most envs are already being run twice with the two files) |
1.) Added max_cycles to all env that accept the parameter 2.) Added a check with parameters different from default ones for env that accept them
|
Good stuff, the tests are now 15 mins instead of 30 mins |
Description
I deleted all the repeted lines in
parametrized_envsfromall_parameters_combs_tests.py, and changed lines where the kwargs where matching with default arguments with an empty dict, so now the test will run with default args also if they will be changes in init func.Type of change
Screenshots
This is an exmaple of what I changed, the first highlighted line now has an empty dict instead of hand_size=5 and the second and third lines have been deleted.
Checklist:
pre-commitchecks withpre-commit run --all-files(seeCONTRIBUTING.mdinstructions to set it up)pytest -vand no errors are present.pytest -vhas generated that are related to my code to the best of my knowledge.