Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back ObsDict and ActionDict #1077

Merged
merged 12 commits into from Aug 27, 2023
Merged

Conversation

pimpale
Copy link
Contributor

@pimpale pimpale commented Aug 25, 2023

Description

Adds back ObsDict and ActionDict to the pettingzoo.utils.env module.

Fixes Farama-Foundation/Shimmy#106 .

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pimpale
Copy link
Contributor Author

pimpale commented Aug 25, 2023

Question: how can we mark a constant as deprecated? Stack Overflow has some solutions, but they seem a bit heavyweight.

@elliottower
Copy link
Collaborator

Question: how can we mark a constant as deprecated? Stack Overflow has some solutions, but they seem a bit heavyweight.

Honestly don't think we need to deprecate it, they're fine for people to use and could make things simpler for new users, we just happen to not use them internally anymore for this repo (but on shimmy I'll probably just leave it as is)

@elliottower
Copy link
Collaborator

It's giving TypeError: 'type' object is not subscriptable in CI btw, not sure exactly how to fix that or what the difference is between what was there previously

@pimpale
Copy link
Contributor Author

pimpale commented Aug 26, 2023

The issue was using dict instead of typing.Dict.

@elliottower elliottower merged commit 9a820fb into Farama-Foundation:master Aug 27, 2023
33 checks passed
@RedTachyon
Copy link
Member

@elliottower Shouldn't this be pushed in a hotfix release asap? At the moment this completely breaks all multiagent stuff in shimmy unless you manually downgrade PZ

@elliottower
Copy link
Collaborator

Yeah that's the plan sorry I've just not had a chance to write up release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PettingZoo Update breaks Shimmy
3 participants