Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order enforcing wrapper fix #1205

Merged

Commits on May 6, 2024

  1. Remove items from OrderEnforcing __getattr__

    The following were removed:
    
    value == "unwrapped" - will never be triggered because the base class has an unwrapped property which returns the same result
    
    value == "render_mode" - duplicates the effect of the base class's __getattr__.
    
    value == "possible_agents", "observation_spaces", "action_spaces", and "agent_order" - not related to the stated goal of the class
    dm-ackerman committed May 6, 2024
    Configuration menu
    Copy the full SHA
    4fdf004 View commit details
    Browse the repository at this point in the history
  2. Correct OrderEnforcingWrapper docstring

    The previous one did not accurately reflect the class behavior.
    dm-ackerman committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a39366e View commit details
    Browse the repository at this point in the history
  3. Remove unused variable from OrderEnforcingWrapper

    _has_rendered was never used
    dm-ackerman committed May 6, 2024
    Configuration menu
    Copy the full SHA
    efe36d0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    62ee638 View commit details
    Browse the repository at this point in the history
  5. Fix pyright errors in AECOrderEnforcingIterator

    The problem stemmed from the iterator being based on AECEnv
    but accessing env._has_updated which only exists in the
    OrderEnforcingWrapper.
    
    Pyright's error is correct based on the types given in the code.
    However, the usage of the class is correct. This is a workaround
    that uses a more precise type and convinces pyright that the code
    is correct.
    dm-ackerman committed May 6, 2024
    Configuration menu
    Copy the full SHA
    cf83ab1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5bfe998 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Ignore pyright error

    dm-ackerman committed May 7, 2024
    Configuration menu
    Copy the full SHA
    12a9d63 View commit details
    Browse the repository at this point in the history