Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Prospector #779

Merged
merged 1 commit into from Sep 5, 2022
Merged

Pull Prospector #779

merged 1 commit into from Sep 5, 2022

Conversation

jjshoots
Copy link
Member

@jjshoots jjshoots commented Sep 4, 2022 •
edited by pseudo-rnd-thoughts

This pulls prospector and all related references throughout the library.

@jjshoots
Copy link
Member Author

jjshoots commented Sep 4, 2022

@pseudo-rnd-thoughts could you review this, should be fairly easy.

pseudo-rnd-thoughts
pseudo-rnd-thoughts approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but could you add a comment on why it is being removed

@jkterry1
Copy link
Member

jkterry1 commented Sep 5, 2022

The environment doesn't serve an interesting use, has had large bugs since inception, has unfixable horrible code and you can't learn any interesting behaviors in it

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit cdab539 into Farama-Foundation:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjshoots @jkterry1 @pseudo-rnd-thoughts