New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check when registering gym compatibility envs to avoid gymnasium warning #29
Merged
pseudo-rnd-thoughts
merged 13 commits into
Farama-Foundation:main
from
pseudo-rnd-thoughts:gymnasium-gym-compatibility
Feb 16, 2023
Merged
Add check when registering gym compatibility envs to avoid gymnasium warning #29
pseudo-rnd-thoughts
merged 13 commits into
Farama-Foundation:main
from
pseudo-rnd-thoughts:gymnasium-gym-compatibility
Feb 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseudo-rnd-thoughts
changed the title
Remove gym compatibility to avoid gymnasium warning
Add check when registering gym compatibility envs to avoid gymnasium warning
Jan 19, 2023
19 tasks
20 tasks
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, gymnasium requires shimmy as a core dependency of the project.
However, this has been noted as an issue for some projects - #23
Therefore, to fix this issue and for backward compatibility, gymnasium will register the compatibility environments which will request that users install
shimmy[gym]
.However,
gymnasium.register
will raise a warning if overwriting environments already registered with the same name.To avoid this issue, we pop the registered environment before registering the environments in shimmy