Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM lab dockerfile & CI tests #52

Merged
merged 6 commits into from Mar 29, 2023

Conversation

elliottower
Copy link
Collaborator

Description

This PR adds a dockerfile and CI workflow for DM-lab. The install script which is referenced in the documentation is also adapted to work on both MacOS and Linux and included as a separate shell script in /scripts/, matching meltingpot which also requires a manual install script.

Fixes # (issue), Depends on # (pull request)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Screenshots

Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower
Copy link
Collaborator Author

This was originally going to be part of the other PR (#51) but that got merged, so the history shows the first two commits from that PR.

Copy link
Member

@jjshoots jjshoots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@elliottower elliottower merged commit 5eef8c6 into Farama-Foundation:main Mar 29, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants