Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOMAPPO Implementation for CrazyRL #20

Merged
merged 14 commits into from
Dec 27, 2023
Merged

MOMAPPO Implementation for CrazyRL #20

merged 14 commits into from
Dec 27, 2023

Conversation

umutucak
Copy link
Collaborator

@umutucak umutucak commented Dec 5, 2023

I've ported over @ffelten's MOMAPPO for continuous env implementation to the momaland API.

This implementation uses single objective collapse with MAPPO. Rewards are scalarized using the LinerizeReward wrapper at Line 206.

To generate the weights, there is a loop outside of the training where we iterate over the weights we want. That is at Line 519.

@umutucak umutucak self-assigned this Dec 5, 2023
@umutucak umutucak marked this pull request as ready for review December 14, 2023 17:27
Copy link
Collaborator

@ffelten ffelten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good :-).

momaland/learning/continuous_ppo/wrappers.py Outdated Show resolved Hide resolved
results/MOMAPPO_Catch_0.1-0.9_1.csv Outdated Show resolved Hide resolved
momaland/learning/continuous_ppo/momappo_crazyrl.py Outdated Show resolved Hide resolved
momaland/learning/continuous_ppo/momappo_crazyrl.py Outdated Show resolved Hide resolved
momaland/learning/continuous_ppo/momappo_crazyrl.py Outdated Show resolved Hide resolved
momaland/learning/continuous_ppo/momappo_crazyrl.py Outdated Show resolved Hide resolved
momaland/learning/continuous_ppo/momappo_crazyrl.py Outdated Show resolved Hide resolved
momaland/learning/continuous_ppo/momappo_crazyrl.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ffelten ffelten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but mostly LGTM

momaland/learning/continuous/cooperative_momappo.py Outdated Show resolved Hide resolved
momaland/learning/continuous/cooperative_momappo.py Outdated Show resolved Hide resolved
momaland/learning/continuous/cooperative_momappo.py Outdated Show resolved Hide resolved
momaland/learning/continuous/cooperative_momappo.py Outdated Show resolved Hide resolved
momaland/learning/continuous/cooperative_momappo.py Outdated Show resolved Hide resolved
@ffelten ffelten merged commit 7fa3590 into main Dec 27, 2023
10 checks passed
@ffelten ffelten deleted the learning/momappo_crazyrl branch December 27, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants