Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows 3.10 build capability #15

Merged
merged 11 commits into from
Jun 3, 2023

Conversation

onaclov2000
Copy link
Contributor

Calling build_windows.bat on a system that has docker installed should build you a whl file, at which point you can pull it out of the container, and pip install it, and it works on windows.

@onaclov2000
Copy link
Contributor Author

I'm not sure why the pre-commit is failing, I thought the flake8 or whatever stuff automatically fixes certain issues and doesn't fail on that, based on the output it looks like it's complaining about trailing whitespace?

@onaclov2000
Copy link
Contributor Author

Finally ran flake8 stuff locally so pre-commit passes.

@MatPoliquin MatPoliquin merged commit 78f4c86 into Farama-Foundation:master Jun 3, 2023
6 checks passed
@pseudo-rnd-thoughts
Copy link
Member

@onaclov2000 Would you be able to add a version of this that runs in CI with github actions?
I think that we can run it with a single version. This will just allow us to know that the windows build still works and none of our other code breaks

@onaclov2000
Copy link
Contributor Author

@pseudo-rnd-thoughts I don't know a whole lot about github actions yet, I'm not sure how to either call docker, and run docker, or call all the commands referenced in docker individually if that makes sense. I might give it a shot later, but I'm not sure how fast I'll be able to do that.

@pseudo-rnd-thoughts
Copy link
Member

For reference, this is how we do docker based CI testing in gymnasium - https://github.com/Farama-Foundation/Gymnasium/blob/main/.github/workflows/build.yml

@onaclov2000
Copy link
Contributor Author

Ahh not sure how I missed that, interesting. Does it actually build the package for each of the tested targets?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants