Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the Condition parameterless constructor obsolete #146

Merged
merged 11 commits into from
May 29, 2023

Conversation

jdromeiro
Copy link
Contributor

Description

  • Modify calls to use the new Condition ctor
  • Turn Condition parameterless obsolete
  • Renamed method in condition builders that accept a condition to Condition()

Change checklist

  • Code follows the code rules guidelines of this project
  • Commit messages follow the commit rules of this project
  • I have self-reviewed my changes before submitting this pull request
  • I have covered new/changed code with new tests and/or adjusted existent ones
  • I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@jdromeiro jdromeiro changed the title Set the Condition parameterless constructor obsolete [WIP] Set the Condition parameterless constructor obsolete May 25, 2023
@jdromeiro jdromeiro requested review from carlosgoias and luispfgarces and removed request for carlosgoias May 25, 2023 13:52
luispfgarces
luispfgarces previously approved these changes May 25, 2023
@jdromeiro jdromeiro force-pushed the refactor_condition_builders branch from c3d8073 to 2d08ecd Compare May 25, 2023 16:57
@jdromeiro jdromeiro changed the title [WIP] Set the Condition parameterless constructor obsolete Set the Condition parameterless constructor obsolete May 25, 2023
@jdromeiro jdromeiro self-assigned this May 25, 2023
@jdromeiro jdromeiro merged commit d85f397 into master May 29, 2023
2 checks passed
@luispfgarces luispfgarces deleted the refactor_condition_builders branch March 22, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants