fix(types): include bubble on press

FaridSafi · Apr 29, 2022 · 94ddd44 · 94ddd44
1 parent 17e23a4
commit 94ddd44
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/example/App.tsx b/example/App.tsx
@@ -2,7 +2,7 @@ import MaterialIcons from '@expo/vector-icons/MaterialIcons'
 import * as Linking from 'expo-linking'
 import AppLoading from 'expo-app-loading'
 import React, { Component } from 'react'
-import { StyleSheet, View, Text, Platform } from 'react-native'
+import { StyleSheet, View, Text, Platform, Alert } from 'react-native'
 import {
   Bubble,
   GiftedChat,
@@ -256,6 +256,9 @@ export default class App extends Component {
           scrollToBottom
           onLongPressAvatar={user => alert(JSON.stringify(user))}
           onPressAvatar={() => alert('short press')}
+          onPress={() => {
+            Alert.alert('Bubble pressed')
+          }}
           onQuickReply={this.onQuickReply}
           keyboardShouldPersistTaps='never'
           renderAccessory={Platform.OS === 'web' ? null : this.renderAccessory}

diff --git a/flow-typedefs/GiftedChat.js.flow b/flow-typedefs/GiftedChat.js.flow
@@ -96,7 +96,8 @@ export type GiftedChatProps<TMessage: IMessage = IMessage> = $ReadOnly<{|
   renderAvatar?: ((AvatarProps<TMessage>) => React.Node) | null,
   renderBubble?: (BubbleProps<TMessage>) => React.Node,
   renderSystemMessage?: (SystemMessageProps<TMessage>) => React.Node,
-  onLongPress?: (context: any, message: any) => void,
+  onPress?: (context: any, message: TMessage) => void,
+  onLongPress?: (context: any, message: TMessage) => void,
   renderMessage?: (MessageProps<TMessage>) => React.Node,
   renderMessageText?: (MessageTextProps<TMessage>) => React.Node,
   renderMessageImage?: (MessageImageProps<TMessage>) => React.Node,

diff --git a/src/GiftedChat.tsx b/src/GiftedChat.tsx
@@ -166,8 +166,10 @@ export interface GiftedChatProps<TMessage extends IMessage = IMessage> {
   renderBubble?(props: Bubble<TMessage>['props']): React.ReactNode
   /*Custom system message */
   renderSystemMessage?(props: SystemMessageProps<TMessage>): React.ReactNode
+  /* Callback when a message bubble is pressed; default is to do nothing */
+  onPress?(context: any, message: TMessage): void
   /* Callback when a message bubble is long-pressed; default is to show an ActionSheet with "Copy Text" (see example using showActionSheetWithOptions()) */
-  onLongPress?(context: any, message: any): void
+  onLongPress?(context: any, message: TMessage): void
   /* Reverses display order of messages; default is true */
   /*Custom message container */
   renderMessage?(message: Message<TMessage>['props']): React.ReactNode